search

ishovkun / SierraBreeze

OSX-like window decoration for KDE Plasma written in C++
355 stars 40 forks source link

The X on the close button isn't symmetrical #5

Closed GrayJack closed 6 years ago

GrayJack commented 6 years ago

The X formed by the 2 lines in the close button isn't horizontally symmetrical

ishovkun commented 6 years ago

Please submit a screenshot. I don't see any asymmetry.

GrayJack commented 6 years ago

sierrabreeze

ishovkun commented 6 years ago

Weird, I don't have this issue. Are you using the latest version?

GrayJack commented 6 years ago

Yeah, latest commit

GrayJack commented 6 years ago

Should I compile using another parameter in the cmake command that you recommend on readme?

ishovkun commented 6 years ago

Which parameter? Well, try to. Are you using a hi-DPI screen? Anything peculiar in your setup?

GrayJack commented 6 years ago

Not really, I'm using a 23" 1080p screen with nothing special

ishovkun commented 6 years ago

The cross in the Close button is defined in lines 214-215 of the file breezebutton.cpp. Try to play with the values. That's the only suggestion I can give you. Sorry about that, man. Another solution could be to set a larger width for the QPen object used to draw the hover hints.

GrayJack commented 6 years ago

When I change the "hint_pen" to "pen" in the line 213 it gets symmetrical, but the X flickers white before it gets black There anything I can do to remove that flicker? Not really used to C++ and Qt libs... sorry

ishovkun commented 6 years ago

I just made a new commit with a new thickness for the hint pen. Try that out.

GrayJack commented 6 years ago

Just tested, and yeah, it got symmetrical screenshot_20171214_234221

ishovkun commented 6 years ago

Awesome. I'm closing this then.