search

ishti-du / RateMyProfessorPlus

0 stars 3 forks source link

Models #14

Closed bew5294 closed 3 years ago

bew5294 commented 3 years ago

Why? Adds the models in which the data will be stored for the rate my professor plus app.

What Changed? Added classes to models.py and added migration files based on these new models. Also added the new models to the admin view.

Discussion / Considerations I want to make sure I have touched on everything needed for the website to work properly. Comment if you see something that looks out of place, should be changed or should be added. I also want opinions on what should be done with foreign keys in other tables when the data it is referring to is deleted. Currently, most are set to cascade on delete.

QA / User Acceptance Tested manually adding data via the admin view.

ishti-du commented 3 years ago

@ChrisCee2, @mbc5954 @MCoutts : Can you guys help me review Bradley'c doe and approve if you find it okay. Thanks.

ChrisCee2 commented 3 years ago

I quickly looked over the code and it looks good. Seems like it has all the necessary models from what we discussed in class and each model has the right attributes. The models look good to start working on everything planned.