search

isi-nlp / DiplomacyAMR

AMR-related aspects of Diplomacy ALLAN project
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Using "and" for :arg1 in demilitarize-01 #33

Closed saramosher888 closed 2 years ago

saramosher888 commented 2 years ago

Currently the AMR Checker will not allow me to use "and" as :arg1 of demilitarize-01. Often there are two countries agreeing to demilitarize a province, so I need to be able to use "and".

Examples: dip_train_0029.27, dip_validation_0006.8

uhermjakob commented 2 years ago

I think the problem is not so much the "and" under :arg1 of demilitarize-01. As per guidelines at https://www.isi.edu/~ulf/amr/lib/amr-dict-diplomacy.html, the AMR Editor expects the :arg1 of demilitarize-01 to be a country (and the :arg2 to be a province or sea). For smosher's dip_train_0029.27, the :arg1 is a conjunction of fleets (not countries), for dip_validation_0006.8 it's a conjunction of a sea and a province, which you might have intended to be :arg2 as opposed to :arg1.

saramosher888 commented 2 years ago

I see. You caught something I missed. I fixed it. Thanks.