search

isi-nlp / DiplomacyAMR

AMR-related aspects of Diplomacy ALLAN project
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

small annotation issues #40

Closed uhermjakob closed 2 years ago

uhermjakob commented 2 years ago
  1. Used non-Diplomacy AMR concept disband-01. Should probably be remove-01.
  2. In dip_train_0009.325, dip_train_0009.326 support-01 has same :ARG0 as :ARG1 (support-01 ENG ENG), which would mean a country supports itself. Could you double-check?
uhermjakob commented 2 years ago

demilitarize-01 should generally use :ARG1 (country) and :ARG2 (province), not :ARG0 (country).

smosher search demilitarize-01 :ARG0 ...

saramosher888 commented 2 years ago
  1. I fixed disband-01 in dip_validation_0007.264. That was a mistake. It should have been dislodge-01.
  2. "ENG" should have been ECH, not England. I fixed both.
saramosher888 commented 2 years ago

I corrected 11 examples where the :arg0 of demilitarize-01 needed to be changed to :arg1. At least this is a quick fix!