search

isi-usc-edu / qb-gsee-benchmark

Apache License 2.0
0 stars 0 forks source link

Fixes to schemas and problem instances #21

Closed max-radin closed 1 week ago

max-radin commented 1 week ago

This PR fixes a few mistakes in the solution schema and also updates the problem instances that were removed by CI in the last commit to comply with the new schemas. Note that each task has been assigned a new UUID that differs from the fcidump UUIDs, as discussed in https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/14.

jtcantin commented 1 week ago

Ah, I've done this too on branch *jtcantin-problem_instance_updates https://github.com/isi-usc-edu/qb-gsee-benchmark/tree/jtcantin-problem_instance_updates, including for the planted solutions and coarse set.

I am planning to add several reference energies next.

@Max, can you check if our schema fixes are the same? *

On 2024-11-19 20:47, Max Radin wrote:

This PR fixes a few mistakes in the solution schema and also updates the problem instances that were removed by CI in the last commit to comply with the new schemas. Note that each task has been assigned a new UUID that differs from the fcidump UUIDs, as discussed in #14 https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/14.

    You can view, comment on, or merge this pull request online at:

https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21

    Commit Summary

(2 files https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21/files)

— Reply to this email directly, view it on GitHub https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC6NAOTUUCTJNTJ2SDRBRD2BPS2LAVCNFSM6AAAAABSDORBOCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TIMBWGA2TQMI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

--------------ZyiGaxY5IP0XGrr17lNoUZkM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

<!DOCTYPE html>

Ah, I've done this too on branch jtcantin-problem_instance_updates, including for the planted solutions and coarse set.

I am planning to add several reference energies next.

@Max, can you check if our schema fixes are the same?


On 2024-11-19 20:47, Max Radin wrote:

This PR fixes a few mistakes in the solution schema and also updates the problem instances that were removed by CI in the last commit to comply with the new schemas. Note that each task has been assigned a new UUID that differs from the fcidump UUIDs, as discussed in #14.

You can view, comment on, or merge this pull request online at:

  https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21

Commit Summary

File Changes

(2 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <isi-usc-edu/qb-gsee-benchmark/pull/21@github.com>


--------------ZyiGaxY5IP0XGrr17lNoUZkM--

jtcantin commented 1 week ago

Actually, I'll just pull this branch into mine and resolve any merge conflicts that may arise.

jtcantin commented 1 week ago

@max-radin This PR for branch max-radin/solver-details seems to only change the schemas. Are there changes on the max-radin/schema-fixes branch that you wanted to include?

max-radin commented 1 week ago

Whoops, opened a PR for the wrong branch. Will close and make a new one.