search

isi-usc-edu / qb-gsee-benchmark

Apache License 2.0
0 stars 0 forks source link

summary_csv and json validation workflows error on pull request #30

Open jtcantin opened 1 week ago

jtcantin commented 1 week ago

When making a pull request but before it is accepted, Github runs both the csv summary and json validation workflows. They seem to error out even if the problem instances pass validation after merging. That is, the json validation workflow executes properly once the PR is accepted/merged, but not at pre-acceptance time.

For csv summary, one issue is just compatibility with the new schema (I'll start a separate issue for this).

Though, the json validation workflow errors out when it attempts to commit. That is, it seems the workflow is trying to commit within the "workflow action virtual machine", but receives the error that it is not on a branch. See attached screenshots from PR #29

The csv summary workflow also involves a commit, so I presume it would error out at that point as well.

I think one simple fix would be to have two separate workflows for each; one for merging, and one for pull requests.

image

image

jtcantin commented 1 week ago

Low priority as this fix is just needed for the future, not by the next deadline.