isi-vista / adam

Abduction to Demonstrate an Articulate Machine
MIT License
11 stars 3 forks source link

Categorical nodes don't have a `label` attribute #1114

Closed lichtefeld closed 2 years ago

lichtefeld commented 2 years ago

(Categoricals don't yet carry a label.)

I suppose that's not a bug strictly speaking (so long as all values across all categories are unique) but given the uniqueness guarantee isn't enforced anywhere it seems like a bug waiting to happen. I'll open a new issue to discuss this because there's a reasonable argument for not adding a category label

Originally posted by @lichtefeld in https://github.com/isi-vista/adam/issues/1102#issuecomment-1069176872

This isn't strictly a bug for the reasons I listed above however introducing a label attribute would be reasonable for a few reasons: