search

isi-vista / adam

Abduction to Demonstrate an Articulate Machine
MIT License
11 stars 3 forks source link

`log_experiment` expects value for `observer_path` even when you specify `log_learner_state: false` #1137

Closed spigo900 closed 2 years ago

spigo900 commented 2 years ago

log_experiment should be able to run and log hypotheses without logging learner state and without specifying a value for observer_path. However, what actually happens is that it crashes (with a NameError, I think) whenever it tries to do the hypothesis logging, because log_learner_state isn't getting checked at the point where we use observer_path.

This is not too terrible a problem. Leaving log_learner_state on when it's not needed doesn't hurt much -- it only costs a small amount of disk space and write time.

This looks like an easy fix.

lichtefeld commented 2 years ago

Ah! I encountered this as well and solved it by just logging state as well.