isi-vista / adam

Abduction to Demonstrate an Articulate Machine
MIT License
10 stars 4 forks source link

Value of variable `nodes_seen` never changes #1173

Closed boyleconnor closed 2 years ago

boyleconnor commented 2 years ago

The variable nodes_seen appears 5 times in the and is always equal to 0. I still don't completely understand how the stroke-merging code is supposed to work, so I'm not sure if this causes undesired behavior or is just a redundancy that can be factored out.

boyleconnor commented 2 years ago

It seems to me like there should be a line:

nodes_seen += n_nodes

at the end of each iteration

spigo900 commented 2 years ago

I agree, there should be.