isi-vista / adam

Abduction to Demonstrate an Articulate Machine
MIT License
10 stars 4 forks source link

SpatialPaths have ambiguity between source and destination which should be resolved #932

Closed lichtefeld closed 4 years ago

lichtefeld commented 4 years ago

Currently our SpatialPath is made up of an operator and a reference_object (or region). To solve disambiguation between the source and destination objects the SpatialPath should just be refactored to have two reference_objects a source_object and destination_object

This will require going through all our situation dictionaries and templates to update for the new structure of the SpatialPath which is probably a several hour process.

lichtefeld commented 4 years ago

@denizbeser Before I go to implement this solution does it make sense to you?

denizbeser commented 4 years ago

@LichMaster98 This makes sense to me. Let me know if you run into any issues!

lichtefeld commented 4 years ago

950 Adds both a source and destination reference object to Spatial Paths. The translation into graphs should be accurate for our representation as the "source" is marked as BEFORE and the destination is marked as AFTER.

It may make sense for whoever is going to do this to make notes of any paths they are unsure how to implement and get feedback from

paynesa commented 4 years ago

Using this comment to track things to discuss/uncertainties: