Closed nicomitchell closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@29fca52
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## master #28 +/- ##
=========================================
Coverage ? 91.82%
=========================================
Files ? 7
Lines ? 575
Branches ? 0
=========================================
Hits ? 528
Misses ? 47
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
immutablecollections/immutableset.py | 89.11% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 29fca52...0489d6c. Read the comment docs.
@nicomitchell : We also need to add a test which would have failed before this fix
@ConstantineLignos : is this clear to merge?
Looks good to me.
if item == 0 or -1
error from #25 :grimacing: