search

isi-vista / immutablecollections

A library for immutable collections, in the spirit of Guava's Immutable Collections.
MIT License
3 stars 2 forks source link

25 conditional error #28

Closed nicomitchell closed 5 years ago

nicomitchell commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@29fca52). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage          ?   91.82%           
=========================================
  Files             ?        7           
  Lines             ?      575           
  Branches          ?        0           
=========================================
  Hits              ?      528           
  Misses            ?       47           
  Partials          ?        0
Impacted Files Coverage Δ
immutablecollections/immutableset.py 89.11% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29fca52...0489d6c. Read the comment docs.

gabbard commented 5 years ago

@nicomitchell : We also need to add a test which would have failed before this fix

gabbard commented 5 years ago

@ConstantineLignos : is this clear to merge?

ConstantineLignos commented 5 years ago

Looks good to me.