search

isi-vista / immutablecollections

A library for immutable collections, in the spirit of Guava's Immutable Collections.
MIT License
3 stars 1 forks source link

Remove ImmutableList #45

Closed berquist closed 5 years ago

berquist commented 5 years ago

Closes https://github.com/isi-vista/immutablecollections/issues/42.

codecov[bot] commented 5 years ago

Codecov Report

Merging #45 into master will increase coverage by 0.31%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   90.23%   90.55%   +0.31%     
==========================================
  Files           7        6       -1     
  Lines         676      614      -62     
==========================================
- Hits          610      556      -54     
+ Misses         66       58       -8
Impacted Files Coverage Δ
immutablecollections/immutablecollection.py 100% <100%> (ø) :arrow_up:
immutablecollections/_immutablemultidict.py 91.72% <100%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f5b3ab...9be49cb. Read the comment docs.

gabbard commented 5 years ago

@berquist: I'm sure you realize this, but we shouldn't merge this until at least https://github.com/isi-nlp/isi-flexnlp/issues/490 is done.

berquist commented 5 years ago

https://github.com/isi-vista/vistautils, https://github.com/isi-nlp/isi-flexnlp, and https://github.com/isi-vista/vistanlp-sandbox no longer use ImmutableList. Poof!