search

isi-vista / immutablecollections

A library for immutable collections, in the spirit of Guava's Immutable Collections.
MIT License
3 stars 1 forks source link

Implement slicing for singleton immutable sets. #57

Closed spigo900 closed 4 years ago

spigo900 commented 5 years ago

Resolves #23.

codecov[bot] commented 5 years ago

Codecov Report

Merging #57 into master will decrease coverage by 1.54%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #57      +/-   ##
=========================================
- Coverage   90.85%   89.3%   -1.55%     
=========================================
  Files           6       7       +1     
  Lines         645     664      +19     
=========================================
+ Hits          586     593       +7     
- Misses         59      71      +12
Impacted Files Coverage Δ
immutablecollections/_immutableset.py 90.98% <100%> (+0.26%) :arrow_up:
immutablecollections/converter_utils.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f198390...a7dcf2b. Read the comment docs.

spigo900 commented 4 years ago

@berquist Thanks for the review. I appreciate the comments. I think I've addressed all of them -- let me know if I missed anything.