search

isi-vista / immutablecollections

A library for immutable collections, in the spirit of Guava's Immutable Collections.
MIT License
3 stars 1 forks source link

Changed typing to work with the `--disallow-any-generics` flag on vistautils #73

Closed jamart28 closed 4 years ago

jamart28 commented 4 years ago

Closes #72

jamart28 commented 4 years ago

I forgot to run make precommit and it seems that this raises an issue with immutable collections itself. I will work on fixing this.

codecov[bot] commented 4 years ago

Codecov Report

Merging #73 into master will decrease coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   89.34%   89.31%   -0.04%     
==========================================
  Files           7        7              
  Lines         676      674       -2     
==========================================
- Hits          604      602       -2     
  Misses         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df73582...e7a3e63. Read the comment docs.

jamart28 commented 4 years ago

@gabbard I'm still unable to request review from @lichmaster98.

gabbard commented 4 years ago

GitHub says he has not yet accepted the invite.

lichtefeld commented 4 years ago

Apologies! I thought I had accepted this.

gabbard commented 4 years ago

Let's put this on hold until https://github.com/python/mypy/issues/5738 is fixed.