search

isi-vista / vista-pegasus-wrapper

A higher-level API for ISI Pegasus, adapted to the quirks of the ISI Vista group
MIT License
2 stars 1 forks source link

Conda script runs Python script twice #98

Closed spigo900 closed 3 years ago

spigo900 commented 3 years ago

The Conda job script template is (in 0.2.0 at least) generating two lines to run the Python script. Example:

echo
echo `which python`
echo python -m ai2.stat_analysis /nas/home/jcecil/pegasus_working/mics/mf-jm-jc-leaderboard-paper/compare_models/stat_analysis/____params.params
python -m ai2.stat_analysis /nas/home/jcecil/pegasus_working/mics/mf-jm-jc-leaderboard-paper/compare_models/stat_analysis/____params.params 2>&1 | tee /nas/home/jcecil/pegasus_working/mics/mf-jm-jc-leaderboard-paper/compare_models/stat_analysis/___stdout.log

echo `which python`
echo python -m ai2.stat_analysis /nas/home/jcecil/pegasus_working/mics/mf-jm-jc-leaderboard-paper/compare_models/stat_analysis/____params.params
python -m ai2.stat_analysis /nas/home/jcecil/pegasus_working/mics/mf-jm-jc-leaderboard-paper/compare_models/stat_analysis/____params.params 2>&1 | tee /nas/home/jcecil/pegasus_working/mics/mf-jm-jc-leaderboard-paper/compare_models/stat_analysis/___stdout.log

The relevant line is 233. Because PYTHON_JOB is a multiline string, we end up with a blank echo line, followed by two PYTHON_JOB blocks.

lichtefeld commented 3 years ago

@spigo900 -- Are you going to submit a PR to fix this or should I do so and then update the pypi version?

spigo900 commented 3 years ago

@lichtefeld If you could, I'd appreciate it. If not I will probably get to it sometime tomorrow afternoon.