search

isindir / sops-secrets-operator

Kubernetes SOPS secrets operator
Mozilla Public License 2.0
323 stars 30 forks source link

error in test-connection pod #68

Closed yogeek closed 3 years ago

yogeek commented 3 years ago

When deploying the operator from the chart with helm 3 :

helm template sops-secrets-operator sops/sops-secrets-operator  --namespace=${SOPS_NAMESPACE}  --set image.tag=0.2.0

a pod called sops-secrets-operator-test-connection is created from this template but always failed because it is base on a busybox image and launches the kubectl binary which is missing.

Is this test is meant to work as is ... ?

Apparently, one can pass the --no-hooks option to skip deploying the templates located in the tests folder. Do you think the installation instruction could be updated with this information ?

helm template sops-secrets-operator sops/sops-secrets-operator  --namespace=${SOPS_NAMESPACE}  --set image.tag=0.2.0 --no-hooks
isindir commented 3 years ago

Hi @yogeek , latest version of chart does not suppport that old version of image, I'd suggest to migrate your deployment to the latest helm chart/image. From the version you mentioned API is changed slightly, so you'd need to change your sops secrets to upgrade.

yogeek commented 3 years ago

Helloe @isindir , what do you mean by old version of image ? I took the default version set by the values.yaml : 0.2.0 (which s also the latest release in github). Can you be more specific please ?

isindir commented 3 years ago

sorry - mixed it with 0.0.2...

isindir commented 3 years ago

Hello @yogeek , I removed breaking test suite - it was pretty useless anyway, I could add RBAC templates to it, but then rbac resources stayed in the namespace even after test has finished. And checking if pods are running is not extremely useful anyway.

isindir commented 3 years ago

closing