when `output` is an object with a `write` method, write directly to it

isislovecruft / python-gnupg

A modified version of python-gnupg, including security patches, extensive documentation, and extra features.

Other

424 stars 172 forks source link

when `output` is an object with a `write` method, write directly to it #210

Open JamesMaroney opened 6 years ago

JamesMaroney commented 6 years ago

if output is an object implementing a write method, pass gpg output directly to it rather than accumulating it in memory.

JamesMaroney commented 6 years ago

Note: I am unable to get most of the tests passing on my machine right now - various issues. I believe the tests I added are accurate, but have not been able to verify them yet myself.

I am interested in any feedback/discussion, as this general functionality is pivotal to my needs - but my implementation of it is certainly only one of many possibilities.

instantname commented 6 years ago

@JamesMaroney Regarding the tests, I had similar issues and the recent PR #206 gives a summary of the errors I had. Maybe you can compare the failures you see with mine.