Version parsing from gpg on windows fails, given a '\r' line end output instead of '\n' from gpg.exe

isislovecruft / python-gnupg

A modified version of python-gnupg, including security patches, extensive documentation, and extra features.

Other

426 stars 171 forks source link

Version parsing from gpg on windows fails, given a '\r' line end output instead of '\n' from gpg.exe #267

Open salvadorparra opened 4 years ago

salvadorparra commented 4 years ago

https://github.com/isislovecruft/python-gnupg/blob/784571449032e811587249743e183fc5e908a673/pretty_bad_protocol/_meta.py#L530

While trying to implement on windows 10, _VERSION_RE does not match because gpg subprocess outputs '2.2.17\r'. May version_line.splitlines()[0] be used instead?