search

isitchristmas / web

Main site.
https://isitchristmas.com
MIT License
251 stars 66 forks source link

Wrong lang attribute #156

Open Wawet76 opened 4 years ago

Wawet76 commented 4 years ago

The lang attribute in the html tag is always set to "en" :

The web site is translated, so this value is wrong when the user is in a non English speaking country.

This attribute should indicate the main language used on the web site, or be removed.

konklone commented 4 years ago

What's the impact of this attribute being wrong for a non-English speaker?

ghost commented 4 years ago

what's the impact of this?

the impact is purely semantic.

since many sites have this attribute wrong anyways and/or content of the webpage can be in several languages, browsers, parsers and crawlers dont rely on it to be the final truth for language determination.

realistically, not even slight SEO-score difference in comparison to the correct solution, big OCD-score dive tho.

Wawet76 commented 9 months ago

It's used by some screen readers for accessibility for blind people.... More commonly (but not needed for isitchristmas) : It's used by browsers to choose default spellchecker to use on inputs.