isivisi / questionablemodules

My collection of VCVRack modules
Other
4 stars 1 forks source link

Modules crash Rack when opening module browser #45

Closed pgatt closed 10 months ago

pgatt commented 10 months ago
Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   plugin.dylib                           0x12cbb0dc0 QuestionableWidget::setWidgetTheme(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, bool) + 32
1   plugin.dylib                           0x12cbaeccc QuestionableWidget::step() + 124
2   libRack.dylib                          0x100b68fe4 rack::app::browser::ModelBox::createPreview() + 504
3   libRack.dylib                          0x100b68930 rack::app::browser::ModelBox::draw(rack::widget::Widget::DrawArgs const&) + 36
4   libRack.dylib                          0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
5   libRack.dylib                          0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
6   libRack.dylib                          0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
7   libRack.dylib                          0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
8   libRack.dylib                          0x100bd24a0 rack::ui::ScrollWidget::draw(rack::widget::Widget::DrawArgs const&) + 48
9   libRack.dylib                          0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
10  libRack.dylib                          0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
11  libRack.dylib                          0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
12  libRack.dylib                          0x100bde6e0 rack::window::Window::step() + 1728
13  libRack.dylib                          0x100bde008 rack::window::Window::run() + 40
14  Rack                                   0x1000fa7e0 main + 3428
15  dyld                                   0x1a44cff28 start + 2236
pgatt commented 10 months ago

Realised I was using my own build, the library version doesn't crash on opening the module browser, may not be an issue.

isivisi commented 10 months ago

What commit did you build with? there was a point were the code was unstable upon closing vcv, but never on load. at least on master.

pgatt commented 10 months ago

I was on a previous build (not sure which) but I pulled a fresh copy of master just before I posted the issue. Rack crashed when I opened the module browser.

isivisi commented 10 months ago

I can take a look around around and see if im doing anything drastic, problem is I see you're on a mac and Ive got no easy access to those. Do the Nightly builds run? if so then I may be doing something that only works with a particular development environment

isivisi commented 10 months ago

nevermind I found a specific instance it can crash, enabling the dark mode setting in vcv and trying to open the browser causes it.

isivisi commented 10 months ago

oops forgot merging closes the issue, do the latest changes solve the problem for you?

pgatt commented 10 months ago

Sure does! Thanks for being so responsive!

isivisi commented 10 months ago

no problem :)