isivisi / questionablemodules

My collection of VCVRack modules
Other
4 stars 1 forks source link

Instant crash when adding any Questionable Module in VCV Rack 2.5.1 #78

Closed morganmay closed 2 months ago

morganmay commented 2 months ago

Whenever I add any of the modules from this plugin to a patch in VCV Rack 2.5.1, Rack instantly crashes. Here's the relevant bit of the log from a crash after adding SLURP:

[7.898 info src/app/Browser.cpp:88 chooseModel] Creating module Questionable Modules SLURP
[7.906 fatal adapters/standalone.cpp:49 fatalSignalHandler] Fatal signal 6. Stack trace:
29: ./Rack() [0x40435d]
28: /usr/lib/libc.so.6(+0x3c770)
27: /usr/lib/libc.so.6(+0x8d32c)
26: /usr/lib/libc.so.6(gsignal+0x18)
25: /usr/lib/libc.so.6(abort+0xd7)
24: ./libRack.so(+0x279854)
23: ./libRack.so(__cxxabiv1::__terminate(void (*)())+0x6)
22: ./libRack.so(+0x7bc631)
21: ./libRack.so(+0x7bc784)
20: ./libRack.so(std::__throw_logic_error(char const*)+0x3d)
19: /home/username/.local/share/Rack2/plugins-lin-x64/questionablemodules/plugin.so(+0xacc8f)
18: /home/username/.local/share/Rack2/plugins-lin-x64/questionablemodules/plugin.so(QuatOSC::QuatOSC()+0x13c)
17: /home/username/.local/share/Rack2/plugins-lin-x64/questionablemodules/plugin.so(rack::createModel<QuatOSC, QuatOSCWidget>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)::TModel::createModule()+0x1f)
16: ./libRack.so(+0x382816)
15: ./libRack.so(rack::app::browser::ModelBox::onButton(rack::widget::Widget::ButtonEvent const&)+0x2a9)
14: ./libRack.so(rack::widget::Widget::onButton(rack::widget::Widget::ButtonEvent const&)+0xed)
13: ./libRack.so(rack::widget::Widget::onButton(rack::widget::Widget::ButtonEvent const&)+0xed)
12: ./libRack.so(rack::widget::Widget::onButton(rack::widget::Widget::ButtonEvent const&)+0xed)
11: ./libRack.so(rack::ui::ScrollWidget::onButton(rack::widget::Widget::ButtonEvent const&)+0x103)
10: ./libRack.so(rack::app::browser::Browser::onButton(rack::widget::Widget::ButtonEvent const&)+0xfd)
9: ./libRack.so(rack::ui::MenuOverlay::onButton(rack::widget::Widget::ButtonEvent const&)+0x11d)
8: ./libRack.so(rack::widget::OpaqueWidget::onButton(rack::widget::Widget::ButtonEvent const&)+0x105)
7: ./libRack.so(rack::widget::EventState::handleButton(rack::math::Vec, int, int, int)+0x269)
6: ./libRack.so(_glfwPollEventsX11+0xfdf)
5: ./libRack.so(rack::window::Window::step()+0x84)
4: ./libRack.so(rack::window::Window::run()+0x28)
3: ./Rack(main+0xe7d)
2: /usr/lib/libc.so.6(+0x25cd0)
1: /usr/lib/libc.so.6(__libc_start_main+0x8a)
0: ./Rack() [0x404289]

I get a similar crash when I add any of the other modules.

As far as I can tell, this started happening after the update to VCV Rack 2.5. I'm using the version of this plugin installed from the VCV Library with the vcvrack-bin 2.5.1-2 AUR package on Arch Linux. I tried removing and reinstalling the plugin, but that didn't help.

Thanks for your work on this plugin; SLURP is one of my favorite oscillators to play with!

isivisi commented 2 months ago

Interestingly I am also using vcvrack-bin 2.5.1-2 from the aur and have not encountered this issue yet :o

I just grabbed the 2.1.13 build from the library and it all works perfectly so far... weird

If its any module on construct then it could be something to do with the config file. They moved the location of the user folder so it should be in ~/.local/share/Rack2/questionablemodules.json. Maybe check to see if that is corrupt in some way? If you post it here don't forget to omit the gitPersonalAccessToken if you set one from Night-bin.

I'll be taking a peek at my code here just incase im doing something odd :P

edit: purposefully breaking my own questionablemodules.json causes the exact same error messages to appear. deleting the file and letting it regenerate should fix issue for now I hope :)

isivisi commented 2 months ago

I've pushed a change that will automatically regenerate the plugins settings if it can't read it properly, you can try it out in the nightly build: https://github.com/isivisi/questionablemodules/releases/tag/Nightly

Let me know if that helps

morganmay commented 2 months ago

I missed the JSON file when I tried deleting the plugin data earlier. Deleting it and then reopening Rack did the trick. Thanks again!