search

iskandr / fancyimpute

Multivariate imputation and matrix completion algorithms implemented in Python
Apache License 2.0
1.25k stars 178 forks source link

TypeError in NuclearNormMinimization #57

Closed Squared2020 closed 6 years ago

Squared2020 commented 6 years ago

Hello, in attempts to execute the Nuclear Norm example, I obtain a TypeError in the _create_objective function:

S = cvxpy.Variable(m, n, name="S") TypeError: init() got multiple values for keyword argument 'name'

Typically this is a 'self' call error, but that doesn't appear to be the case here. Thoughts?

apurvg14 commented 6 years ago

I am facing the same error. In fact, the readme example throws the same error when run.

sergeyf commented 6 years ago

Looks like cvxpy.Variable has changed its syntax. It should probably be S = cvxpy.Variable((m, n), name="S"). We don't have requirements for our cvxpy, but probably should.

Either of you willing to submit a PR that updates use of cvxpy to correct syntax and add a version to the requirements file? Should be very straight-forward, but it would be good to have someone with a use-case do it so we can make sure nothing is breaking.