search

isl-org / Open3D-ML

An extension of Open3D to address 3D Machine Learning tasks
Other
1.86k stars 319 forks source link

Add tum facade dataset #613

Closed ThomasFroech closed 11 months ago

ThomasFroech commented 1 year ago

added dataset classes for the TUM-Facade dataset (https://github.com/OloOcki/tum-facade ) and updated the init file

This change is Reviewable

ssheorey commented 1 year ago

Hi @ThomasFroech can you add a readme.md for the dataset with this information:

Website: Download: Data License: Leaderboard: Citation:

ThomasFroech commented 1 year ago

Hi @ssheorey,

Hi @ThomasFroech can you add a readme.md for the dataset with this information:

There is a README.md available in the original GitHub repo (https://github.com/OloOcki/tum-facade). I think that all important information is there. While the data can be downloaded from that source, I would recommend obtaining it from this location instead. Here, the data is organized into training, validation, and testing sets. The data structre is described in the small README.txt that is available, there:

https://tumde-my.sharepoint.com/:f:/g/personal/olaf_wysocki_tum_de/EjA8B_KGDyFEulRzmq-CG1QBBL4dZ7z5PoHeI8zMD0JxIQ?e=9MrMcl

Hi @ThomasFroech this PR modifies the API for update_probs(). Can you explain the reasoning behind that?

I'm sorry, but I'm not entirely sure about the specific point you're referring to. Would you kindly provide me with a hint or more details to help me better understand?

ThomasFroech commented 11 months ago

@ssheorey

Hi @ThomasFroech this PR modifies the API for update_probs(). Can you explain the reasoning behind that?

My intention was solely to add the tumfacade.py file and make corresponding adjustments to the __init__.py file. I did not have any intention to alter or adapt any other components.