search

isl-org / Open3D

Open3D: A Modern Library for 3D Data Processing
http://www.open3d.org
Other
11.28k stars 2.28k forks source link

How does VisualizerWithEditing bound a KeyCallback? #1370

Open MikoyChinese opened 4 years ago

MikoyChinese commented 4 years ago

Hi, guys

I try to get the picked point value from VisualizerWithEditing, But when I want to add a label name to the point I just picked, the process is blocked, I can't do anything until I quit the window. But I just want to picked a point and label it, not to label a point list.

And I found the class VisualizerWithKeyCallback, which has keycallback function but no get_picked_point. So how can I bound a keycallback for VisualizerWithEditing and do something I want? Anybody help? Thanks.

Best, Mikoy Chinese

sammo2828 commented 4 years ago

As far as I can see, this is a current limitation because VisualizerWithKeyCallback and VisualizerWithEditing are independent subclasses of Visualizer.

There is another issue that "it seems strange to have a separate class for a visualizer which has a keyboard callback" https://github.com/intel-isl/Open3D/issues/737#issuecomment-451011339

In my fork of open3d, I have keyboard callback features directly implemented as part of the base Visualizer class. This way, even VisualizerWithEditing has keyboard callback features, and there is no need for a separate VisualizerWithKeyCallback.

I'll raise a pull request with my changes for discussion. Stay tuned.

germanros1987 commented 4 years ago

Hi! In the Open3D team, we take your question very seriously. In order to provide better assistance to our users, we are implementing new policies. Now general questions should be asked in our forum: https://forum.open3d.org

Github issues will remain in use for bug reports and feature requests.

We are looking forward to answering your question in our forum!

Best regards.