isl-org / Open3D

Open3D: A Modern Library for 3D Data Processing
http://www.open3d.org
Other
11.35k stars 2.29k forks source link

Documentation for registration_fgr_based_on_feature_matching not updated #6997

Open aragonnetje6 opened 2 weeks ago

aragonnetje6 commented 2 weeks ago

Checklist

Describe the issue

the registration for registration_fgr_based_on_feature_matching was not updated after the rename of the function from registration_fast_based_on_feature_matching

Steps to reproduce the bug

read documentation at https://www.open3d.org/html/python_api/open3d.registration.registration_fast_based_on_feature_matching.html#open3d.registration.registration_fast_based_on_feature_matching

Error message

No response

Expected behavior

No response

Open3D, Python and System information

- Operating system: Ubuntu 20.04
- Python version: Python 3.8
- Open3D version: 0.18.0
- System architecture: x86
- Is this a remote workstation?: yes
- How did you install Open3D?: pip

Additional information

No response

RubensBenevides commented 8 hours ago

This is really a problem, there is no way to convert a numpy array to a feature in the standard version. I can do it with tensors, which solves the problem, but another problem is the computations of FPFH on all points of the cloud, instead of only on keypoints, for exemple, using ISS keypoint detector. the computation takes to much time in TLS point clouds. Someone should implement a way to compute FPFH only on some indexes.

RubensBenevides commented 8 hours ago

select_by_index should also work with the Feature object