Closed Christos-Ps closed 1 year ago
Dear @thias15 Please create the folder using the name XL_lego_body as it describes beter what is inside (there is an XL version with no lego bricks on top) Please find attached the readme file together with the STL files [OpenBot DIY - XL lego - Readme.docx](https://github.com/isl-org/OpenBot/files/11051036/OpenBot.DIY.-.XL.lego.-.Rea OpenBot - XL lego.zip dme.docx)
Dear @thias15
It seems i closed this "Pull Request" as i had the wrong impression that this was needed for you to proceed, so i reopened it now. Therefore you can pretty much skip my past comments..
Following our last communication, Please create the folder using the name "XL_lego_body" as it describes beter what is inside this folder. There are 2 body top types and 1 body bottom:
An increased height (XL) short version with front bumper and sleak top (no lego compatible) An increased height (XL) short version with front bumper and lego compatible top A short version body bottom with front bumper matching the 1-2 top types. Please find attached the readme file along with the STL files. OpenBot DIY - XL lego - Readme.docx OpenBot - XL lego.zip
Best Regards Christos
@Christos-Ps. Ok, usually PR includes all the changes you want to propose. But I can take care of it.
Thanks @thias15 !!
I tried to create a file directly in https://github.com/isl-org/OpenBot/tree/master/body/diy/cad but i wasn't allowed to upload any files, so i tried to do it here instead.. Nevertheless please feel free to let me know if i can help any further!
Cheers! Christos
You would have to do this in a fork, and then create a PR based on a branch in your fork.
But I can prepare a PR and then you can review if that's easier.
@Christos-Ps there seems to be some problems with the stl files. Could you please also provide the step files.
@Christos-Ps also made a new PR #348 that adds a compatible README file, pending the STEP files and fixed STL files (I can also generate them if you provide me the step files). You can check it out here.
Hi @thias15
I am afraid that i have no step files, as i made all changes with MeshMixer & Tinkercad. What i have except from the STL files are the .OBJ files that i also exported from Tinkercad and i am uploading here, hoping that you can use them instead of the STEP files (or be able to convert them to STEP files). I can see now that OpenBot logo on the top part looks corrupted and in am afraid that was probably a "side effect" somewhere along the MeshMixer transformations i did that elluded me as it wasn't also so clear on my Ultimaker Cura preview.
OpenBot-Short_Body_Bottom.zip
OpenBot-Short_Body_Top_Extra_Height_Bricks_Final.zip
OpenBot-Short_Body_Top_Extra_Height.zip
Please feel free to let me know of the outcome! P.S. If you feel that the attached .OBJ files will do for the PR #348, please let me know to upload them there as well!
Cheers Chris
Hi @Christos-Ps. I checked the .obj files. Unfortunately they have the same artefacts. It is generally best to use the step files for making modifications (ideally in Fusions 360 - free for one year or a similar software). Working on the stl-meshes directly often creates problems. Would you be willing to redesign this model in Fusion360 to avoid such artefacts? I know this is extra work, but would be greatly appreciated. If not, would it be ok for you if we reimplement your design?
Hi @thias15
It's a bit of overload on my side, but it can be also a good chance to learn a new software! :) I downloaded Fusion360 and reworked the bottom part (unfortunately i had to create also bottom in order for top+bottom to perfectly align when assembled. I am uploading now in #348 the bottom part stl+Step files, and i will recreate the upper part in Fusion360 and upload it when ready (hopefully within the next 7-10 days max). Let me know for anything extra or comments!
@Christos-Ps thanks for your willingness to learn something new and putting in the extra effort. Once you get familiar with Fusion360 I'm sure you will love it. It is very powerful.
@Christos-Ps note that no files have been added to this PR. Please let us know once it's ready for review.