search

isl-org / OpenBot

OpenBot leverages smartphones as brains for low-cost robots. We have designed a small electric vehicle that costs about $50 and serves as a robot body. Our software stack for Android smartphones supports advanced robotics workloads such as person following and real-time autonomous navigation.
https://www.openbot.org
MIT License
2.77k stars 513 forks source link

When using one phone as Wifi AP and the other connect to this AP, controller app and robot app can NOT connect #387

Closed yijunwu closed 6 months ago

yijunwu commented 7 months ago

Describe the bug When using one phone as Wifi AP and the other connect to this AP, controller app and robot app can NOT connect

To Reproduce Steps to reproduce the behavior:

  1. Two phones, lets say A and B. Start Wifi Access Point on A
  2. On phone B, connect to that Wifi provided by A
  3. Run robot App on A, select phone as control mode; Run controller App on B
  4. Robot app can not find controller app (service) hence from user point of view, controller can't connect to robot

Expected behavior When using one phone as Wifi AP and the other connect to this AP, controller app and robot app can connect. This will be a convinient way to allow users to use phone control mode even in out-door scenario.

Smartphone (please complete the following information):

Additional context I've worked out a fix for this issue, will create PR soon.

yijunwu commented 7 months ago

I've create a PR (https://github.com/isl-org/OpenBot/pull/388) to fix this. Please kindly review and merge.

hardikgarg02 commented 6 months ago

Its working fine for android. Can you also check same functionality for IOS application.

yijunwu commented 6 months ago

Its working fine for android. Can you also check same functionality for IOS application.

I'll take a look, but I'm not familiar with iOS dev, so I'm not sure how much time it'll take.