search

isl-org / TanksAndTemples

Toolbox for the TanksAndTemples benchmark website
Other
86 stars 23 forks source link

Updating Evaluation Code #23

Closed griegler closed 4 years ago

griegler commented 4 years ago

I updated the evaluation code:

  1. Using current version open3d and assume it is installed in the Python path. Therefore, no need for configs in setup.py.
  2. Moved the other necessary parameters to the command prompt in run.py. Again, no more changes in setup.py needed to get the evaluation running. Script is now started for each scene independently.
  3. Removed dependency on compiled open3d examples. Implemented the color coding in pure Python.

In general, this should generate the very same output. The only thing that might slightly differ is the color coding, because I am not certain that the hot color map as implemented in open3d is the very same as implemented in matplotlib.

griegler commented 4 years ago

@syncle @arknapit

syncle commented 4 years ago

Thanks Gernot, I will have a look

2020년 1월 16일 (목) 오후 6:35, Gernot notifications@github.com님이 작성:

@syncle https://github.com/syncle @arknapit https://github.com/arknapit

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intel-isl/TanksAndTemples/pull/23?email_source=notifications&email_token=AELTCGLTB6FEYZ4RGTPGUW3Q6AZ6DA5CNFSM4KHRV452YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJDSX7I#issuecomment-575089661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELTCGJFJOKPUDCDYWSRDE3Q6AZ6DANCNFSM4KHRV45Q .

arknapit commented 4 years ago

I still have no write access btw.

arknapit commented 4 years ago

LGTM with minor comments. @arknapit, could you try to test this PR, and confirm it is ok with you?

I tried it out, works fine. Good to merge with me. Thx @griegler for keeping it updated.

syncle commented 4 years ago

@arknapit @griegler Thanks for the work!