isl-org / spear

SPEAR: A Simulator for Photorealistic Embodied AI Research
MIT License
224 stars 15 forks source link

Do we need to check the `MSPresets` folder into Perforce? #210

Open RachithP opened 1 year ago

RachithP commented 1 year ago

The MSPresets folder in Perforce seems to have the same content as Engine\Plugins\Bridge\Content\MSPresets, which is installed by default as part of the Quixel Bridge plugin.

Additionally, the kujiale_0000 scene seems to depend on both Engine\Plugins\Bridge\Content\MSPresets and the copy of MSPresets in Perforce. The evidence for this is as follows. Uninstalling the Quixel Bridge plugin and cooking the kujiale_0000 scene results in missing materials, as explained in https://github.com/isl-org/spear/issues/209. This shows that kujiale_0000 depends somehow on the Quixel Bridge plugin, but doesn't show that kujiale_0000 depends on any particular plugin file. However, running build_paks.py without adding SpearSim\Saved\Cooked\Platform\Windows\Engine\Plugins to the paks_dir list results in rendering artifacts (see images below). This strongly suggests that kujiale_0000 depends on the Engine\Plugins\Bridge folder.

Is this dependency intended? What is the benefit of having a local copy MSPresets, since this folder is already included by default in the engine? Are there any differences between our local copy and the engine copy?

[Edited by @mikeroberts3000 for brevity, and to clarify that only the MSPresets folder is potentially redundant. The original text suggested that Megascans and MSPresets folders are both potentially redundant, but there is no Megascans folder in Engine/Plugins/Bridge.]

image image