search

isl-org / spear

SPEAR: A Simulator for Photorealistic Embodied AI Research
MIT License
224 stars 15 forks source link

improved utils in Std and Unreal classes, camera enabled when paused #264

Closed mikeroberts3000 closed 6 months ago

mikeroberts3000 commented 6 months ago

Thank you for reviewing this in detail and finding some great things to fix! 😄

mikeroberts3000 commented 6 months ago

Note that I previously thought it would not be practical for our entry points to take const references as input arguments. I thought this because we often want to construct std::span objects from input std::vector objects, and I didn't think it was practical to construct a std::span<T> object from a const std::vector<T>& reference. But I realized this is actually pretty clean and easy. So we can keep the convention that our entry points take const references as input, and we don't need to use the mutable keyword in our new work queue implementation.