refactor code to create various service classes under new `SpEngine` plugin

isl-org / spear

SPEAR: A Simulator for Photorealistic Embodied AI Research

MIT License

224 stars 15 forks source link

Closed RachithP closed 5 months ago

RachithP commented 5 months ago

Change plugin SimulationController -> SpEngine
Add old SimulationController code under SpEngine/Legacy
Add new classes -> EngineService, GameWorldService, LegacyService, WorkQueue in SpEngine plugin.
Make python side more user friendly and intuitive.
Add clean_project_dir.py to provide a script for cleaning temporary project files.

mikeroberts3000 commented 5 months ago

This whole PR is looking fantastic. I want to take another look before approving but we're definitely on the right track.

mikeroberts3000 commented 5 months ago

Do a find/replace of your entire codebase for tabs. I noticed a couple of tabs in the changed files view.
If our services need to be pointers anyway, then I think we should delete the default constructors.

mikeroberts3000 commented 5 months ago

if value == None -> if value is None
Env methods shouldn't be static. They take as input an Instance, so they need some state to operate, and the state they need is cached in an Env object. What is being gained by making these methods static? Wouldn't it be simpler to call my_env.tick() compared to Env.tick(my_env.instance)?

mikeroberts3000 commented 5 months ago

Use the convention #include "SpCore/Whatever.h" for our own headers. SpEngine currently uses <> for our headers in several places.