search

islandio / island-app

https://www.island.io
MIT License
2 stars 1 forks source link

Delete irrelevant grade consensus? #137

Closed pdusatko closed 9 years ago

pdusatko commented 9 years ago

https://www.island.io/crags/usa/rmnp/boulders/dont-get-too-greedy Shows V8 with only two logged ascents of V13. Can I delete the V8?

sanderpick commented 9 years ago

Yep for sure, but not sure you'll be able to. @eyalcohen, the V8 must be coming from when the ascent was added - maybe that should be more of a "suggested grade" that doesn't affect consensus

eyalcohen commented 9 years ago

Yeah, that V8 grade came from the ascent being imported. Let me think of a good way to deal with bogus grades... in the mean time, I fixed it in the database.

sanderpick commented 9 years ago

Sweet. Seems to make sense to take the ascent adder's grade as more of a "suggestion". To be consistent with the community sentiment, only ascensionists should obtain the right to offer a grade to the consensus. Also makes it a bit more like a game and encourages logging. Sound reasonable?

On Aug 20, 2015, at 12:54 PM, Eyal Cohen notifications@github.com wrote:

Yeah, that V8 grade came from the ascent being imported. Let me think of a good way to deal with bogus grades... in the mean time, I fixed it in the database.

— Reply to this email directly or view it on GitHub.

eyalcohen commented 9 years ago

makes sense... should be an easy change

pdusatko commented 9 years ago

Agreed!

On Aug 20, 2015, at 7:33 PM, Sander Pick notifications@github.com wrote:

Sweet. Seems to make sense to take the ascent adder's grade as more of a "suggestion". To be consistent with the community sentiment, only ascensionists should obtain the right to offer a grade to the consensus. Also makes it a bit more like a game and encourages logging. Sound reasonable?

On Aug 20, 2015, at 12:54 PM, Eyal Cohen notifications@github.com wrote:

Yeah, that V8 grade came from the ascent being imported. Let me think of a good way to deal with bogus grades... in the mean time, I fixed it in the database.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

eyalcohen commented 9 years ago

aaand done (but not live yet). Commit: 1316958

Changes:

  1. Grade consensus chart only shows up for climbs that have been sent
  2. Consensus doesn't include 'suggestions'
  3. A climb changes its grade on first Island ascent
eyalcohen commented 9 years ago

live