Feature/@

[eyalcohen]

... basics are in.

@sanderpick ...

• When UserA mentions UserB, should UserB automatically start following UserA?
• Should we send an Email to UserB when UserA mentions UserB?

[eyalcohen]

Looks good, just a few things to finish up TODO:

• Make sure public/private model for mentions makes sense
• Decide whether to Email people who are mentioned (I think yes but could get spammy)
• Make sure instagram posts work correctly
• Add some test cases

Future:

• Typing @ brings up a chooser

[sanderpick]

Hell yes.

• When UserA mentions UserB, should UserB automatically start following UserA?

maybe we just sub them to whatever the parent thread is - post, tick, crags, or ascent? I think that's how commenting is currently handled. We'd want a "leave conversation"/"unwatch" button deletes the subscription

• Should we send an Email to UserB when UserA mentions UserB?

how bout adding another notification config setting for @ mentions, email is currently the only notification type other than "in-app", which can't be turned off... eventually we add sms etc

[eyalcohen]

This is more or less ready @sanderpick

[eyalcohen]

if you want to review it, there are changes in island-events you should check out

[eyalcohen]

maybe we just sub them to whatever the parent thread is - post, tick, crags, or ascent? I think that's how commenting is currently handled. We'd want a "leave conversation"/"unwatch" button deletes the subscription

done

how bout adding another notification config setting for @ mentions, email is currently the only notification type other than "in-app", which can't be turned off... eventually we add sms etc

done

Make sure public/private model for mentions makes sense

People can mention in private and enhanced private modes. We can add logic to deal with this but I don't think its a big deal.

Decide whether to Email people who are mentioned (I think yes but could get spammy)

in

Make sure instagram posts work correctly

ignoring instagrams, they have a different post mechanism and we'd need to correlate @ mentions

Add some test cases

done

Typing @ brings up a chooser

would be a good project for a new developer

[sanderpick]

Nice one @eyalcohen ... This rules! Checked it out and works like a charm. Made a tiny tweak to notification model (https://github.com/The-Island/island-app/commit/7bd7f51c52ab961d9696198a07679b09c9bb4c1b). Merging...

[sanderpick]

Deployed :rainbow: :rainbow: