[wip] Feature/mobile - Githubissues

eyalcohen commented 8 years ago

Making Island go mobile.

Big effort with big rewards.

Addresses #152 and #124

varmlandsmaskinen commented 8 years ago

Hell yeah!!

Sent from my iPhone

On Mar 26, 2016, at 3:04 PM, Eyal Cohen notifications@github.com wrote:

Making Island go mobile.

Big effort with big rewards.

Addresses #152 and #124

You can view, comment on, or merge this pull request online at:

https://github.com/The-Island/island-app/pull/156

Commit Summary

wip wip2 wip3 wip4 File Changes

M public/css/style.css (254) M public/css/style.styl (349) M public/js/router.js (41) M public/js/views/chart.scatter.js (17) M public/js/views/lists/events.js (2) M public/js/views/rows/post.js (1) M public/js/views/rows/tick.js (6) M public/js/views/session.new.js (4) M public/templates/lists/events.html (64) M public/templates/profile.html (5) M public/templates/profile.title.html (24) M public/templates/rows/ascent.html (12) M public/templates/rows/crag.html (12) M public/templates/rows/post.html (17) M public/templates/rows/session.html (10) M public/templates/rows/tick.html (33)
M public/templates/tabs.html (11) M public/templates/tick.new.html (26) M views/layout.jade (1) Patch Links:

https://github.com/The-Island/island-app/pull/156.patch https://github.com/The-Island/island-app/pull/156.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

sanderpick commented 8 years ago

So good

On Mar 26, 2016, at 4:46 PM, varmlandsmaskinen notifications@github.com wrote:

Hell yeah!!

Sent from my iPhone

On Mar 26, 2016, at 3:04 PM, Eyal Cohen notifications@github.com wrote:

Making Island go mobile.

Big effort with big rewards.

Addresses #152 and #124

You can view, comment on, or merge this pull request online at:

https://github.com/The-Island/island-app/pull/156

Commit Summary

wip wip2 wip3 wip4 File Changes

M public/css/style.css (254) M public/css/style.styl (349) M public/js/router.js (41) M public/js/views/chart.scatter.js (17) M public/js/views/lists/events.js (2) M public/js/views/rows/post.js (1) M public/js/views/rows/tick.js (6) M public/js/views/session.new.js (4) M public/templates/lists/events.html (64) M public/templates/profile.html (5) M public/templates/profile.title.html (24) M public/templates/rows/ascent.html (12) M public/templates/rows/crag.html (12) M public/templates/rows/post.html (17) M public/templates/rows/session.html (10) M public/templates/rows/tick.html (33) M public/templates/tabs.html (11) M public/templates/tick.new.html (26) M views/layout.jade (1) Patch Links:

https://github.com/The-Island/island-app/pull/156.patch https://github.com/The-Island/island-app/pull/156.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

eyalcohen commented 8 years ago

hey @sanderpick, think this is ready for someone else to play with it. Want to review?

There is quite a bit of work left to do on getting the images / videos to scale correctly, because of how they're asynchronously loaded. Could use some help there, or I'll try to look at it throughout the week.

eyalcohen commented 8 years ago

sanderpick commented 8 years ago

Will checkout this evening!

sanderpick commented 8 years ago

Diving in in the morn

eyalcohen commented 8 years ago

I rebased on your crag ascent changes. They're a bit difficult to incorporate into a mobile site, so I hid them for now.

Other features that are different in mobile mode (max-width <1148px)

Maps and mini-maps are hidden
Crag list / editing tools hidden
Grade preferences in the settings hidden
Import / Download / Clear logs in the settings hidden
Profile image changes in the settings hidden
The row of instagrams in the ascents are hidden
Banner ad on the left is hidden
Event filters (All / Session / Post) are hidden

sanderpick commented 8 years ago

Some quick notes:

feed looks awesome
crag description should be at the top of the crag pages (this may be cumbersome since we're moving sidebar content above the main content)
in crag settings, longitude label is misplaced
search bar should be as wide as possible
clearing search with the "x" should hide the bar
recent ascents sidebar could be reduced to three boulders, three routes
hide followers, followees, and recommended followers?

eyalcohen commented 8 years ago

Ready

crag description should be at the top of the crag pages (this may be cumbersome since we're moving sidebar content above the main content)

I just hid the sidebar content for the crag in mobile.

in crag settings, longitude label is misplaced

Fixed... non-mobile crag settings suffers slightly.

search bar should be as wide as possible

Fixed (hacky)

clearing search with the "x" should hide the bar

Turns out that 'x' only appears in Chrome and fires a 'search' event. The 'search' event isn't used for anything else, oddly enough. Anyway, fixed.

recent ascents sidebar could be reduced to three boulders, three routes

Done

hide followers, followees, and recommended followers?

not yet, but I'm tweaking recommended followers so I'll do it then.

islandio / island-app

[wip] Feature/mobile #156