islco / django-rq-scheduler

A database backed job scheduler for Django RQ and RQ Scheduler
MIT License
42 stars 46 forks source link

delete takes care of unscheduling; admin validation for scheduled time #20

Closed bafio closed 5 years ago

tom-price commented 5 years ago

I'm closing this request for three reasons

  1. The component where delete takes care of unscheduling was merged in with pr #23
  2. There are cases e.g., disabling a job, where it would be reasonable to save a job with at time in the past. I've looked into raising a warning using Django's Messages framework, but the request is not passed through to the ModelForm so don't think theres a case to build off of this work to achieve that.
  3. Saving a job scheduled in the past doesn't cause it to run immediately.