islco / django-rq-scheduler

A database backed job scheduler for Django RQ and RQ Scheduler
MIT License
42 stars 46 forks source link

Pin django-model-utils version to 2.4.0 #37

Closed frbry closed 4 years ago

frbry commented 4 years ago

Looks like django-rq-scheduler only needs django-model-utils==2.4.0. Currently it causes the latest version of django-model-utils to install which dropped Django 1.x and Python 2.x support. This breaks builds on repos still using Python 2.x and Django 1.x.

This PR pins the required version to fix that.

davisagli commented 4 years ago

Please don't do this; it will prevent using a newer version of django-model-utils in projects that wish to do so. If you need an older version of django-model-utils for compatibility with your project, you should pin it in your project's requirements rather than here.

g3rd commented 4 years ago

I second @davisagli Will need to start a discussion on Django version support.