isle-project / isle-editor

Editor for ISLE (Integrated Statistics Learning Environment) lessons.
https://isledocs.com
Other
16 stars 7 forks source link

LearnNormalDistribution and LearnBinomialDistribution #1214

Open jricoiii opened 4 years ago

jricoiii commented 4 years ago

Is your feature request related to a problem? Please describe. n/a

Describe the solution you'd like Would like to see the following features added

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

jricoiii commented 4 years ago

not sure - was this fixed?

Planeshifter commented 4 years ago

No, no changes yet on the distribution components.

Comments on the individual points raised:

  1. I don't think we want re-scaling of the height of the PDF unless you mean that the user should be able to adjust the zoom. Reason being that we want to show how the tails get fatter or narrower, which works best when the y-axis stays the same. In the extreme case where the axes completely adjust, you end up with a situation where the shape of the PDF looks the same no matter what.
  2. Should be doable.
  3. and 4. Yeah, would make sense, will need to check how much work that would entail.
  4. Will change the default maximum of 999 and make it configurable. That's certainly the easiest change from the list.
  5. Reason for the whitespace is that the distribution widget can also display the distribution step function, and we don't use up the entire space when it is hidden. Will reconsider.
jricoiii commented 4 years ago
  1. I agree that if re-scaled all normal dist look exactly the same. Already the x-axis changes as sigma gets bigger or smaller
  1. Just was suggesting if the CDF option is set to false, you could change the width of the PDF