[Bug]: on student lessons, "i" causes "focus trap" error

[gweinberg]

Description

on any ISLE lesson in student mode (for instance, https://isle.stat.cmu.edu/36-200-second-summer-23/worldcup_project2/ -> presentation mode to mimic student mode), when you hit the i key on the keyboard it results in the following error:

Confirmed on Chrome on Win11, as well as Firefox on Win10.

Some student recently stumbled on this problem. Quite unfortunately, the only way out of the bug is to reload the browser, which then removed all the output he had previously made. [Luckily he had been saving screenshots on google doc.]

It seems like for instructors, the i key is a keyboard shortcut to open the instructor panel. For students, perhaps ISLE is still looking for the instructor panel to open and then giving an error when it can't find it?

Expected behavior

the i key should not have any action for students on ISLE lessons.

To Reproduce

see above

Version

0.76.23

Link to ISLE lesson

see above

ISLE Code

No response

What browsers are you seeing the problem on?

No response

What browser version?

No response

Additional context

No response

[Planeshifter]

@gweinberg Problem reproduced and identified, thanks for bringing this to my attention! Working on a fix.

It's of course in hindsight and won't help that student, but when encountering this error and similar ones, clicking the retry button at the top right of the error box can resolve it. For this bug, looks like one does not have to reload the page.

[gweinberg]

@Planeshifter As a follow up, I got curious what other keyboard shortcuts there might be that could cause problems, so I tried all the letters of the alphabet on https://isle.stat.cmu.edu/36-200-second-summer-23/worldcup_project2/ (in presentation mode), and the following are potentially problematic:

• The lowercase "g" pulls up a group manager. Should this happen in presentation mode? Would this happen for students as well?
• The lowercase "q" pulls up the question queue. Should this happen in presentation mode? Would this happen for students as well?

[Planeshifter]

@gweinberg Just confirmed the following:

• For a student, the "g" hotkey does not do anything.
• For a student, the "q" hotkey does open the question queue where they can submit a question, which is sensible and as expected.

Of course, we could disable the hotkeys like the question queue and the group manager in the presentation mode for instructors. Happy to make that change.

[gweinberg]

cool thanks for checking