isledecomp / SIEdit

Tools for working with SI files.
GNU General Public License v3.0
133 stars 8 forks source link

SIEdit crashes when opening JUKEBOX.SI #12

Open MatiLol251 opened 7 months ago

MatiLol251 commented 7 months ago

When i open JUKEBOX.SI, SIEdit does nothing at all, before it closes itself. I load it using "Open" and "View SI File" and none of that works The weirdest part is that if i open files such as "NOCD.SI" or "INTRO.SI" the app doesn't crash and can visualize the data correctly Now i wonder why that doesn't happen with "JUKEBOX.SI".. (Edit: i used libweaver build that appears in the "releases" tab)

itsmattkc commented 7 months ago

I can't recreate this on my end - my JUKEBOX.SI opens fine.

Can you share what version/language of LEGO Island you're using? Or alternatively, send your JUKEBOX.SI file in some way?

MatiLol251 commented 7 months ago

it's the spanish version

MatiLol251 commented 7 months ago

maybe it's the fact that the voice samples are in higher quality than the english version. unfortunately, that means that the file is 91mb. No joke

itsmattkc commented 7 months ago

Confirmed the Spanish JUKEBOX.SI crashes libweaver. Will look into a fix for this.

foxtacles commented 5 months ago

I've investigated this issue a couple weeks back and we've found that the issue is in fact that the Spanish JUKEBOX.SI is corrupted. At file offset 0x2be0000, a split chunk is expected, but instead one can find a block of 2048 zero bytes. This trips up SIEdit, as well as the original game (the race theme gets stuck):

https://github.com/isledecomp/SIEdit/assets/1135351/782b3649-cdc4-4fb0-973f-561ecded8ad2

It would be possible to make SIEdit more "lenient" to accomodate for this faulty file though if we want to work around it.

MatiLol251 commented 5 months ago

Yes, I heard that tripping, but i thought it was part of the original release so I didn't think anything of it.