isledecomp / isle

A work-in-progress decompilation of LEGO Island (1997)
1.78k stars 89 forks source link

Refactor various `operator[]` based on BETA10 #1110

Closed jonschz closed 1 month ago

jonschz commented 1 month ago

As discussed in https://github.com/isledecomp/isle/pull/1109#discussion_r1788641625, I have investigated the various index operators in BETA10. Please let me know what you think. Overall, the match percentage on BETA10 goes down a bit, but that is misleading - the correctness actually increases. As for LEGO1, we see a lot of entropy on changes especially in vector.h. I will add some details below. Overall, I have not found that anything seriously breaks in LEGO1, but I'd appreciate if someone else took a look.