isleofcode / corber

CLI for building hybrid apps with Ember/Vue/Glimmer/Cordova
http://corber.io
MIT License
334 stars 100 forks source link

plugin cordova-plugin-whitelist #696

Open mival opened 3 years ago

mival commented 3 years ago

Plugin cordova-plugin-whitelist is not longer compatible with android platform

Installing "cordova-plugin-whitelist" for android
Plugin doesn't support this project's cordova-android version. cordova-android: 10.1.1, failed version requirement: >=4.0.0 <10.0.0

but corber validator still require it.

bummzack commented 2 years ago

While trying to update an application so that it runs on Android 11, I've encountered the same issue. With cordova-android 10.x this plugin is no longer required, but somehow corber relies on it to be present (even when it's not installed). Is there a way to use corber with cordova-android 10.x or later?

mival commented 2 years ago

@bummzack my solution was remove plugin dependency from corber validator. After that corber builds and works still fine

bummzack commented 2 years ago

@mival Any pointers how to do that? I can't seem to find that corber validator anywhere…

mival commented 2 years ago

@bummzack validator is added in https://github.com/isleofcode/corber/blob/master/lib/targets/cordova/target.js#L51. So if you comment .push out, it should work