Template compilation is broken when adding ember-cli-asset-sizes-shim

isleofcode / ember-cli-asset-sizes-shim

Shim for future ember-cli feature

MIT License

12 stars 3 forks source link

Template compilation is broken when adding ember-cli-asset-sizes-shim #5

Closed MiguelMadero closed 1 year ago

MiguelMadero commented 8 years ago

Normally the template will look something like:

define("spoof-ui/templates/index", ["exports"], function (exports) {
  exports["default"] =....

After adding this:

define("spoof-ui/templates/index", ["exports"], function (exports) {
  define("spoof-ui/templates/index", ["exports"], function (exports) { 
    exports["default"]

This breaks since we don't really have a template, but another function.

I tested this with ember-cli 2.9.1 and ember 2.9.0 and 2.10-beta.1

runspired commented 8 years ago

@MiguelMadero confirm, I've warned about this before, it's sadly only useful to install, check sizes, uninstall, until I figure out what's broken where.

MiguelMadero commented 8 years ago

Ok. Sounds good. Thanks for confirming. Should I add a warning on the README?

On Thu, Oct 27, 2016 at 9:34 AM Chris Thoburn notifications@github.com wrote:

@MiguelMadero https://github.com/MiguelMadero confirm, I've warned about this before, it's sadly only useful to install, check sizes, uninstall, until I figure out what's broken where.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/isleofcode/ember-cli-asset-sizes-shim/issues/5#issuecomment-256628358, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC5HApUbN90d0IcJMTKW67C9BIL-Ziwks5q4JpHgaJpZM4KhjZm .