Closed zpzigi754 closed 4 months ago
This refactoring is what I have been wanting to see! Thanks for bringing this up :)
Do you think it is better to leave the definition of realm, Rd, inside rmi? I think it is more appropriate to place it inside realm.
Good question! I also think that most of the data structures including Rd
and Rec
are better to be placed outside the current rmi module.
Do you have plan to integrate vcpu and rec too?
Partly yes, but not in the near time. I've refactored Realm
in order to help verify Realm
-related RMIs. So, the integration of vcpu
and rec
would be required before verifying Rec
-related RMIs. The refactoring task itself could be done by another.
This PR contains the refactoring commits related to the earlier discussion (#230). Realm and Rd (Realm Descriptor) have almost the same purpose. It aims to keep only Rd which is defined by spec.
Summary of changes
Notes
vmid
is integrated withid
so that onlyvmid
, passed by the Host, is usedVMID_SET
is used instead of the previousRMS
(Realm Map Struct?)trait Context
and redundantenum State
have been removedChanges in the caller side
A caution