search

islet-project / islet

An on-device confidential computing platform
Apache License 2.0
91 stars 16 forks source link

Revert "Use DUCT-TAPE to fix irq test" #354

Closed L0czek closed 1 month ago

L0czek commented 1 month ago

This reverts commit 2e0f9ffa672f526c91b5a6128cb70df082f33fd4.

It appears that some (maybe Islet) is not handling some IRQ properly. As a result this patch broke reading the attestation token even though the cca-rmm-acs tests were passing. It it most likely due to the fact that the test suite was a simple bare metal binary that doesn't utilize much of the emulated hardware. Reverting this patch doesn't remove any functionality. In the future, the IRQ handling should be investigated.

Havner commented 1 month ago

I've verified that the #350 is fixed with that commit. From my understanding reverting https://github.com/islet-project/islet/commit/2e0f9ffa672f526c91b5a6128cb70df082f33fd4 means that one of ACS tests will start to fail again, but it's of a less importance that being able to fetch the token and perform attestation.

@L0czek please make a note here what github issues is tracking this stuff.

L0czek commented 1 month ago

@L0czek please make a note here what github issues is tracking this stuff.

This issue is tracked in https://github.com/islet-project/islet/issues/352 at

The attestation irq exit test

The attestation_rec_exit_irq attempts to test whether reading the attestation token from rmm can be interrupted by an IRQ. Since, the IRQ is a lower level exception, it cannot interrupt the control flow of Islet. As a result, it needs to be actively checked during RSI handling. [...]