ismaelestalayo / CryptoTracker

Minimal yet powerful crypto-currency tracker UWP.
https://ismaelestalayo.com/projects/CryptoTracker/
GNU General Public License v3.0
63 stars 14 forks source link

Charts disappear in portfolio when certain coins added #23

Closed smogger closed 2 years ago

smogger commented 2 years ago

BUG:

If you add certain coins to your portfolio, the whole chart disappears.

SGB - Songbird EXFI - Flare Finance

The strange thing is that the app is capable to retrieve SGB price, yet the chart is not visible.

Feature request:

Would be nice to have a confirmation pop-up under the portfolio if you plan to remove one coin. If you have a lot of transactions stored under that coin it is not a really pleasant experience if you accidentally remove it. Especially because the "see coin" is just next to it.

Thank you

ismaelestalayo commented 2 years ago

Thanks for the heads up about this double issue. In one hand I'll try to fix the empty charts on these coins (which I guess they are not supported in one of the three APIs I use), and in the other hand, there really should be a warning message when deleting more than one purchase as you said, so i'll add that as well. Thanks

smogger commented 2 years ago

The strange thing is for example:

Sologenic (SOLO) - Price updates (I can see Delta), chart is visible (also if i check only that specific coin) Songbird (SGB) - Price updates (I can see Delta), chart is NOT visible (even If I check that specific coin) Flare Finance (EXFI) - No Price, No Delta, No Chart

Hope this helps debug them cause the errors seems kinda odd and inconsistent.

Found another UI error (refresh button) next to cogwheel disappeared. I can still press it and works.

ismaelestalayo commented 2 years ago

Sorry for taking so long to fix this issue, but it has finally been fixed in the latest version v6.1.4.

The problem happened with coin-pairs not supported in CryptoCompare, like EXFI-EUR or EXFI-USD for example. For now, that coin will not be counted in the historic chart of the Portfolio.

While fixing this bug I also found that some alt-coins had no price data, and could alter the portfolio negatively, so I've added a warning symbol to let users know: image