search

ismaelga / react-json-editor

A dynamic form component for react using JSON-Schema.
https://ismaelga.github.io/react-json-editor
MIT License
225 stars 42 forks source link

array and object handling closer to ie support #7

Closed lapponiandevil closed 8 years ago

lapponiandevil commented 8 years ago

I am still getting some weird double loading in IE, which I don't get in Firefox. Inital load of object still throws in some prototype property (find). A penny for your thoughts.

ismaelga commented 8 years ago

Thanks for the PR! I will probably pull it tomorrow and try to make it fully work on IE. It would be nice if you could test it after, because I don't have windows on my machine.

lapponiandevil commented 8 years ago

I stumbled on a root and fell into a hole, otherwise I would have been on the case. Some unit tests would be a good start, to make sure we don't break the simplest cases...

haf commented 8 years ago

There are unit tests that can be extended now!

ismaelga commented 8 years ago

What version of IE it does not support?

lapponiandevil commented 8 years ago

I tested it with Win 8.1, IE 11. As Microsoft will end support for all but the latest browser on each platform, I don't think that there is need for this project to look at the other ones either.