Closed janblahawebsta closed 2 years ago
janblahawebsta
commented
2 years ago Hi Ismaelw, I'm sorry, I made a fork of your repository, but I accidentally pushed it into yours.
I'm so sorry.
If possible, you can delete this pull request.
If the changes make sense to you, feel free to cherry-pick up the adjustments that will suit you and apply them to your code.
ismaelw
commented
2 years ago HI @janblahawebsta
Alright. I almost thought it has to be something like that. But in all my time I saw a lot of things so I thought I better ask back first :)
For now I will close this pull request and will go through the changes in a later moment. I do would like to know if your changes are "Best Practice Only" or if those changes will prevent possible errors. If you wish you could tell me that!
Take care you guys!
Warm, regards, Ismael
Hi @janblahawebsta
Thank you for your contribution. Please tell me a little bit more about it.
I have to say I was pretty confused seeing this pull request and don't really understand what is going on. Trying to review the changes made me realize that there are a few possible changes that would actually make sense but it's impossible to really review this pull request when 99% of the changes are "remove ismaelw and add webstasolution"
I respectfully ask you to clarify the current situation.
Kind regards, Ismael