search

ismail-s / JTime

Project has moved to https://www.gitlab.com/ismail-s/jtime
https://jtime.ismail-s.com
GNU General Public License v2.0
5 stars 0 forks source link

Make navigation drawer handle route changes better #236

Closed ismail-s closed 7 years ago

ismail-s commented 7 years ago

This line of code needs to be improved so it doesn't just toggle the navigation drawer between open and closed, but closes it only. At the moment, when navigating backwards in history, the drawer opens when it shouldn't.

See google/material-design-lite#1246

I think the best solution is to still call the toggleDrawer function, but to check first (by inspecting css classes) as to whether the drawer is open or not.

ismail-s commented 7 years ago

To clarify, the new functionality is that on all route changes, the nav drawer will be closed if it is open.