search

ismailof / mediacontroller_plus

Modified version of mediacontroller plasma5 widget
GNU General Public License v2.0
30 stars 11 forks source link

[ Request ] - Maximum height #19

Open Davincible opened 3 years ago

Davincible commented 3 years ago

It would be nice if I could limit the height of the media player in a latter panel. So just like there is a max width option, a max height option would also be nice.

Furthermore an option to force one of the specific layouts would also be nice, regardless of absolute size.

ismailof commented 3 years ago

Hi there @Davincible , that's a nice suggestion... the settings for width do not make much sense on a vertical panel, while height settings there do. There is a bit complex though, to make it look nice for different settings and use cases all around without over-complicating the logic.

Would you mind to post a screenshot of your current use case, so I can better understand what's what you'd like to achieve?

About layout selection, I'll be probably porting this to the official applet layout (single layout artwork on the left) which in my opinion looks better that the older one this is currently based on.

Davincible commented 3 years ago

image

This is my setup now. Would be great if we could pick which one of the adaptive layouts we want in there

Davincible commented 3 years ago

So ideally, the settings would have a dropdown, where you can select the different variants

rubin110 commented 3 years ago

Hi there. I was about to ask for a feature request for either a general margin or max height. My use case is slightly different than @Davincible, I'm using the widget on a Latte dock, and it looks a little out of scale with the other icons in the panel.

2021-07-13_12-12-14

I can specify a margin for items in Latte's own application widget through Latte's settings, but it has no effect on other widgets.

Thanks.

Edit: Sorry, pasted the totally wrong the screen shot initially.

Nano-Ocelot commented 2 years ago

To make matters worse. My widget doesn't seem to respect any visibility options when placed in a vertical panel. Here's a screenshot of mine with only the 'album art' box ticked. It displays only the play button, which is unchecked, and not the album art at all. It also takes up a ton of space like described earlier. Screenshot_20210824_142217 Screenshot_20210824_142315

ismailof commented 2 years ago

I see. There it is hitting a width limit which makes it go to icon only mode. That limit was set before the album art option existed. I'll check it up how to fix that for vertical panels.