ismailof / mediacontroller_plus

Modified version of mediacontroller plasma5 widget
GNU General Public License v2.0
30 stars 11 forks source link

Porting to Plasma 6 #32

Open ciachciarachciach666 opened 5 months ago

ciachciarachciach666 commented 5 months ago

Hey ismailof,

Since this is the best media controller addon, are there any chances of it getting ported to Plasma 6?

Thanks!

ismailof commented 5 months ago

I'll start with a bit of digression:

For media players in particular there are two points that require porting:

Were only for the first part, I would have publish the current porting work. But the second point is a bit more tedious, and probably the easiest way is to copy the changes from the official plasmoid.

At this point the official applet already offers two of the characteristics why I started this "fork": panel representation with the song info, and icon tabbar for different players. So I'm wondering if the effort would be best invested into adding the last remaining bits to the official applet (options for formatting the panel view, and panel controls) instead of the inverse.

So, TLDR, I cannot promise there will be a ported version soon :) but I'm considering it.

Thanks for your interest!

ciachciarachciach666 commented 5 months ago

Thanks a lot for the detailed answer! TBH for me the most important parts are control buttons on the taskbar. I've checked and there are no plasmoids with that functionality yet.

MurzNN commented 5 months ago

The same for me, control buttons on the panel is the thing!

metzger100 commented 5 months ago

I don't know if it helps, but I guess that most of the users of "mediacontroller plus" are using it because of the panel controls. The official applet is very limited (There isn't even a settings page). I like the official applet but the missing panel controls are a game breaker for me. On the other side I always had problems with "mediacontroller plus" while using brave browser and the spotify flatpak (other flatpaks had the same problem). The automatic player tab never got it right and selected the paused youtube video in the browser instead of the running spotify song. The official applet is working flawlessly in this case. In my humble opinion an upgrade of the official applet would be better than an update of mediacontroller plus.

jediafr commented 5 months ago

@ismailof I reverted back to plasma 5 for your widget (and alias). Your widget takes the all menu available space, let me adjust the volume by scrolling in there and have the controls icons also, it is very readable and i keep track of the song progression visually. Please consider porting it , it is that awesome ! Some plasma 6 have some of that but not all

UserFooBar commented 4 months ago

Loved it on plasma 5, it's really a shame not to see it on plasma 6. The buttons on the media player are super useful

ReillyBrogan commented 4 months ago

I think that adding the improvements to the upstream widget is the "correct" approach as it will bring the improvements to the most users. However, it also means that the changes wouldn't be available until Plasma 6.1 at minimum which is not ideal. Perhaps use this project as a "staging" area to get those ready for upstreaming before opening MRs to add the improvements to the original widget?